A good lawyer will tell you the truth, like she did. A bad lawyer will let things drag out just to pad their bill.
Think about your goals in terms of priority and recognize you won't get everything you want.
If staying in the house is important to you and your lawyer thinks it's a possibility in the long run, then you COULD just make it the place you sleep at night and keep the rest of your life as separate as possible from your STBX in the meantime. If, on the other hand, being in a rental and away from his craziness will give you peace of mind and is financially doable even if it means a reduced standard of living - consider what that benefit will do for you. I can't remember if this is a rental or a house you own. If it's a rental - a shared home with a good roommate may be much nicer than your current living situation. Only you can decide that - but you were looking forward to the idea of moving away. Just moving out of the house where you are may give you similar relief. Now that you are working you could start saving money towards that goal at least.
Your attorney is right in that your ex can take you to court for almost anything, no matter how ridiculous, if he wants to. Doesn't mean he will win but it will cost you time and energy. Ask your attorney what a reasonable settlement would usually look like in your case. Ask for more but realize that is probably where you will end up and plan accordingly. And realize that there's a benefit to being done and away even if it costs you something to get there.
Try to avoid giving him anything to grab onto in terms of aggravating you. Don't give away all your rights but be strategic about what matters most. And in the meantime, LIVE! Don't put everything on hold in your life. Do fun things and look forward to your future.